fix: ensure CC_ASSERT retain line info #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't find a background to why this inline wrapper existed around the assert call.
hefloryd
reviewed
Apr 9, 2025
| @@ -34,11 +34,6 @@ extern "C" { | |||
| #define CLANG_ANALYZER_NORETURN | |||
| #endif | |||
|
|
|||
| static inline void cc_assert (int exp) CLANG_ANALYZER_NORETURN | |||
There was a problem hiding this comment.
IIRC, the wrapper exists to be able to add the LCOV_EXCL_LINE exclusion marker. Without you must also trigger the assertion for full coverage.
There was a problem hiding this comment.
Feels like a CLANG error?
The function used on linux is this:
extern void __assert_fail (const char *__assertion, const char *__file,
unsigned int __line, const char *__function)
__THROW __attribute__ ((__noreturn__));
It's decorated by noreturn already which should be a harder form.
The Clang-specific ‘analyzer_noreturn’ attribute is almost identical to ‘noreturn’ except that it is ignored by the compiler for the purposes of code generation.
There was a problem hiding this comment.
Ah vänta du menade LCOV_EXCL_LINE. Sorry. Ja den är ju något annat.
|
Will close for now. Will need to figure out how to enable all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't find a background to why this inline wrapper existed around the assert call.