Skip to content

1.0.1#136

Merged
rtuszik merged 10 commits intomainfrom
dev
Sep 15, 2025
Merged

1.0.1#136
rtuszik merged 10 commits intomainfrom
dev

Conversation

@rtuszik
Copy link
Copy Markdown
Owner

@rtuszik rtuszik commented Sep 15, 2025

No description provided.

rtuszik and others added 9 commits September 7, 2025 23:24
Bumps [ty](https://github.com/astral-sh/ty) from 0.0.1a16 to 0.0.1a20.
- [Release notes](https://github.com/astral-sh/ty/releases)
- [Changelog](https://github.com/astral-sh/ty/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ty@0.0.1-alpha.16...0.0.1-alpha.20)

---
updated-dependencies:
- dependency-name: ty
  dependency-version: 0.0.1a20
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [apprise](https://github.com/caronc/apprise) from 1.9.3 to 1.9.4.
- [Release notes](https://github.com/caronc/apprise/releases)
- [Commits](caronc/apprise@v1.9.3...v1.9.4)

---
updated-dependencies:
- dependency-name: apprise
  dependency-version: 1.9.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [requests](https://github.com/psf/requests) from 2.32.4 to 2.32.5.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.32.4...v2.32.5)

---
updated-dependencies:
- dependency-name: requests
  dependency-version: 2.32.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.12.7 to 0.12.12.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.12.7...0.12.12)

---
updated-dependencies:
- dependency-name: ruff
  dependency-version: 0.12.12
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `entrypoint.sh:13` </location>
<code_context>
+    echo "Updating photon group GID from $CURRENT_GID to $PGID"
+    groupmod -o -g "$PGID" photon
+    echo "Updating ownership of files from GID $CURRENT_GID to $PGID"
+    find / -group "$CURRENT_GID" -exec chgrp -h "$PGID" {} \; 2>/dev/null
+fi
+
</code_context>

<issue_to_address>
**suggestion (performance):** Running 'find /' may be slow and affect system files.

Restrict the 'find' command to specific directories to avoid unintended changes and improve execution speed.

```suggestion
    # Restrict find to specific directories to avoid system files and improve speed
    for dir in /home /opt /var; do
        if [ -d "$dir" ]; then
            find "$dir" -group "$CURRENT_GID" -exec chgrp -h "$PGID" {} \; 2>/dev/null
        fi
    done
```
</issue_to_address>

### Comment 2
<location> `entrypoint.sh:20` </location>
<code_context>
+    echo "Updating photon user UID from $CURRENT_UID to $PUID"
+    usermod -o -u "$PUID" photon
+    echo "Updating ownership of files from UID $CURRENT_UID to $PUID"
+    find / -user "$CURRENT_UID" -exec chown -h "$PUID" {} \; 2>/dev/null
+fi
+
</code_context>

<issue_to_address>
**🚨 issue (security):** Changing ownership recursively from root may have unintended consequences.

Limiting the ownership change to application-specific directories will help prevent system instability and security risks.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

echo "Updating photon group GID from $CURRENT_GID to $PGID"
groupmod -o -g "$PGID" photon
echo "Updating ownership of files from GID $CURRENT_GID to $PGID"
find / -group "$CURRENT_GID" -exec chgrp -h "$PGID" {} \; 2>/dev/null
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Running 'find /' may be slow and affect system files.

Restrict the 'find' command to specific directories to avoid unintended changes and improve execution speed.

Suggested change
find / -group "$CURRENT_GID" -exec chgrp -h "$PGID" {} \; 2>/dev/null
# Restrict find to specific directories to avoid system files and improve speed
for dir in /home /opt /var; do
if [ -d "$dir" ]; then
find "$dir" -group "$CURRENT_GID" -exec chgrp -h "$PGID" {} \; 2>/dev/null
fi
done

echo "Updating photon user UID from $CURRENT_UID to $PUID"
usermod -o -u "$PUID" photon
echo "Updating ownership of files from UID $CURRENT_UID to $PUID"
find / -user "$CURRENT_UID" -exec chown -h "$PUID" {} \; 2>/dev/null
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 issue (security): Changing ownership recursively from root may have unintended consequences.

Limiting the ownership change to application-specific directories will help prevent system instability and security risks.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Sep 15, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedapprise@​1.9.3 ⏵ 1.9.473 +1100100100100
Updatedrequests@​2.32.4 ⏵ 2.32.599100100100100
Updatedty@​0.0.1a16 ⏵ 0.0.1a20100100100100100
Updatedruff@​0.12.7 ⏵ 0.12.12100100100100100 +31

View full report

@rtuszik rtuszik merged commit e41be14 into main Sep 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant