Skip to content

refactoring #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
githubCast wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

refactoring #1455

githubCast wants to merge 19 commits into from

Conversation

@githubCast
Copy link

@githubCast githubCast commented Nov 16, 2024

  • moved botToken to TelegramClient
  • replaced getBotToken with getTelegramClient in SpringLongPollingBot

@rubenlagus
Copy link
Owner

rubenlagus commented Nov 19, 2024

What's the benefits of this refactor? Not sure what it adds

@githubCast
Copy link
Author

githubCast commented Nov 20, 2024

What's the benefits of this refactor? Not sure what it adds

Encapsulation: client contains all the necessary parameters to communicate with the server.

@rubenlagus rubenlagus changed the base branch from master to dev November 23, 2024 18:31
@rubenlagus rubenlagus force-pushed the dev branch 3 times, most recently from 52a184e to 9203912 Compare September 7, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@githubCast @rubenlagus @valkuc @therepanic