Feature #1532: Add protected hooks for handling ability restrictions (Input, Locality, Privacy) #1555
+67
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1532
Description
Original enhancement request is to add custom message in case of violation Locality. I moved handling input, locality and privacy violations to separate protected methods so they can be overriden
Changes
checkInput,checkLocality, andcheckPrivacyto delegate error handling to new protected methods instead of hardcoded logic.protected void onInputViolation(Update, Ability)to customize reaction to invalid argumentsprotected void onLocalityViolation(Update, Ability)to customize reaction to locality violations (e.g. Group vs Private).protected void onPrivacyViolation(Update, Ability)to customize reaction to insufficient permissions.Example usage
Developer can now override protected hooks to customize behavior:
Issue #1532