Skip to content

Conversation

@msteckle
Copy link
Collaborator

@msteckle msteckle commented Apr 4, 2025

Thank you for contributing to ILAMB-Data. Use this template when submitting a pull request.

🛠 Issue reference #74

Include a reference to the issue # here.
Summarize the changes you are making to the repo. Are you fixing a bug? Adding a dataset? Describe what you did in a few sentences or bullet points.

  • I added a scripts directory with an init.py file so users can import useful helper functions
    • validate_dataset.py (to check netCDFs)
    • biblatex_builder.py (to create properly formatted biblatex citation strings)
    • helper_funcs.py (to quickly set attributes, encoding, global attributes, and netCDF file naming)
    • compare_datasets.py (I think this was already there?)
  • I shortened the pull request template because I think it would be better to just change the README to include an example of how to use the functions in helper_funcs.py. I can restore the previous pull request template if you're not into this change.
  • Processed GFED5 to close issue GFED5 (burned area) #74

🧪 Testing

Add an x between the brackets to indicate basic testing was completed

  • I inspected the outputted NetCDF and checked for obvious errors
  • I visualized the outputted NetCDF at a timestamp to check for obvious visual errors
  • I compared my convert script to recent existing ones
  • I attempted to create/encode the NetCDF according to CF Compliance guidelines

🧪 (Optional) Preview

Attach an image of your dataset here
output

@msteckle msteckle added enhancement New feature or request new dataset labels Apr 4, 2025
@msteckle msteckle requested a review from nocollier April 4, 2025 13:58
@msteckle msteckle self-assigned this Apr 4, 2025
@msteckle msteckle linked an issue Apr 4, 2025 that may be closed by this pull request
@msteckle msteckle merged commit 28f3cc1 into master Apr 4, 2025
@msteckle msteckle deleted the 74-gfed5-burned-area branch April 4, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new dataset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

GFED5 (burned area)

3 participants