Skip to content

Conversation

@msteckle
Copy link
Collaborator

Thank you for contributing to ILAMB-Data. Use this template when submitting a pull request.

🛠 Summary of changes

Include a reference to the issue # in this section
Fixed HWSD2 bug according to issue #85

🧪 NetCDF Validation

Add an x between the brackets to indicate basic testing was completed

  • Created a new working directory (e.g., ILAMB-DATA/GFED5/)
  • Created a standalone python script that downloads and processes the new dataset (e.g., ILAMB-DATA/GFED5/convert.py)
    • The python script outputs a netcdf (e.g., ILAMB-DATA/GFED5/burntFractionAll_mon_GFED5_199701-202012.nc)
  • Ran python3 validate_dataset.py ILAMB-DATA/GFED5/burntFractionAll_mon_GFED5_199701-202012.nc in command line and resolved any errors
  • Visually inspected the outputted netCDF for obvious issues
    • ncdump -h ILAMB-DATA/GFED5/burntFractionAll_mon_GFED5_199701-202012.nc to visually inspect the netCDF header information
    • ncview ILAMB-DATA/GFED5/burntFractionAll_mon_GFED5_199701-202012.nc to visually inspect the map (where applicable)

🧪 (Optional) Preview

Attach an image of your dataset here
Previous data (top) vs new data (botton) global view:
hwsd2_cSoil_timestep_0
cSoil_fx_HWSD2_19600101-20220101_timestep_0

Previous data (top) vs new data (bottom) zoomed in:
hwsd2_cSoil_SE-US_zoom
cSoil_fx_HWSD2_19600101-20220101_SE-US_zoom

🏎 (Optional) Quality Checklist

Add an x between the brackets to indicate script quality adherence

  • There are no unused libraries imported into the code
  • There are no erroneous console logs, debuggers, or leftover testing code
  • There are no hard-coded paths to your local machine in the script
  • Useful headings describe sections of your code
  • Variable names are generalizable and easy to read

@msteckle msteckle requested a review from nocollier May 15, 2025 19:16
@msteckle msteckle self-assigned this May 15, 2025
@msteckle msteckle added the bug Something isn't working label May 15, 2025
@msteckle msteckle linked an issue May 15, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Errors in HWSD2 dataset

2 participants