Add suggestions for date-related columns#364
Open
fatkodima wants to merge 1 commit intorubocop:masterfrom
Open
Add suggestions for date-related columns#364fatkodima wants to merge 1 commit intorubocop:masterfrom
fatkodima wants to merge 1 commit intorubocop:masterfrom
Conversation
andyw8
reviewed
Feb 15, 2025
| Name `datetime` columns with `_at` suffixes. | ||
| Name `time` columns (referring to a time of day with no date) with `_time` suffixes. | ||
|
|
||
| This enforces consistency and it is easier to tell the type from name without referring to db schema. |
Contributor
There was a problem hiding this comment.
Suggested change
| This enforces consistency and it is easier to tell the type from name without referring to db schema. | |
| This enforces consistency and it is easier to tell the type from the name without referring to the database schema. |
fatkodima
force-pushed
the
date-columns
branch
from
72d815a to
90ff2ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rubocop/rubocop-rails#335 (comment)