Prefer JSON's symbolize_names option instead of ActiveSupport's deep_symbolize_keys#372
Open
viralpraxis wants to merge 1 commit intorubocop:masterfrom
Conversation
…ep_symbolize_keys` ref: rubocop/rubocop-rails#1534
viralpraxis
changed the title
symbolize_names option instead of ActiveSupport's dep_symbolize_keyssymbolize_names option instead of ActiveSupport's deep_symbolize_keys
Member
|
If it’s such a problem, I wonder if AS can somehow mark a freshly parsed object, and issue a warning if deep symbolise is called on it? |
Member
|
Cc @byroot |
It's wasteful, but not necessarily a problem.
Nah, would mean monkey patching JSON, to then add an instance variable on a Hash object, that's too wasteful and dirty. |
Author
|
So does it make sense to implement this rule as a cop? |
Member
|
As a cop - certainly yes. As a guideline - I’m uncertain if it’s worth it. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: rubocop/rubocop-rails#1534