Avoid Kernel.suppress(Exception)#374
Open
viralpraxis wants to merge 1 commit intorubocop:masterfrom
Open
Conversation
koic
reviewed
Oct 26, 2025
ref: rubocop/rubocop-rails#1547 Using `Kernel.suppress(Exception) { ?? }` is effectively equivalent to: ```ruby begin ?? rescue Exception end ``` Since rescuing `Exception` directly is discouraged by `Lint/RescueException`, it makes sense to discourage this usage as well. See https://rubystyle.guide/#no-blind-rescues
viralpraxis
force-pushed
the
kernel-suppress-exception
branch
from
5267c97 to
438bbf5
Compare
Member
|
One concern is that https://rubystyle.guide/#no-blind-rescues is a rule intended to prevent catching exceptions with incorrect handling. On the other hand, |
Author
|
Are there any legitimate uses of On the other hand, its easy to use Anyway, I don't insist of making this a rule, but I think a cop would be beneficial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: rubocop/rubocop-rails#1547
https://api.rubyonrails.org/classes/Kernel.html#method-i-suppress
Using
Kernel.suppress(Exception) { ?? }is effectively equivalent to:Since rescuing
Exceptiondirectly is discouraged byLint/RescueException, it makes sense to discourage this usage as well.