Skip to content

Avoid redundant selector lookup in Capybara/SpecificActions#192

Open
ydah wants to merge 1 commit into
mainfrom
refactor/specific-actions-selector-lookup
Open

Avoid redundant selector lookup in Capybara/SpecificActions#192
ydah wants to merge 1 commit into
mainfrom
refactor/specific-actions-selector-lookup

Conversation

@ydah

@ydah ydah commented Jun 24, 2026

Copy link
Copy Markdown
Member

Avoid the redundant selector lookup in Capybara/SpecificActions.

on_send already normalizes the find argument with last_selector(arg) before calling specific_action. This changes specific_action to use that normalized selector directly when looking up SPECIFIC_ACTION, keeping the behavior the same while making the control flow easier to follow.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • [-] Added the new cop to config/default.yml.
  • [-] The cop is configured as Enabled: pending in config/default.yml.
  • [-] The cop documents examples of good and bad code.
  • [-] The tests assert both that bad code is reported and that good code is not reported.
  • [-] Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • [-] Set VersionChanged: "<<next>>" in config/default.yml.

@ydah ydah requested a review from a team as a code owner June 24, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant