Add Performance/ReduceMerge cop#328
Open
sambostock wants to merge 2 commits into
Open
Conversation
d9dec98 to
0ed5e12
Compare
This cop detects and corrects building up a `Hash` using `reduce` and `merge`, which creates a new copy of the `Hash` so far on each iteration. It is preferable to mutate a single `Hash`, successively adding entries, ideally avoiding small temporary hashes as well.
0ed5e12 to
1d474dc
Compare
sambostock
commented
Jan 2, 2023
7 tasks
`Set#merge` mutates the receiver, like `Hash#merge!`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cop detects and corrects building up a
Hashusingreduceandmerge, which creates a new copy of theHashso far on each iteration.It is preferable to mutate a single
Hash, successively adding entries, ideally avoiding small temporary hashes as well.Real world example/motivation
Reading several hundred thousand key-value pairs from a CSV file to build up a
Hashin memory using the following approach takes on the order of 15 minutes:Meanwhile, building the same
Hashby mutation takes under a secondBenchmark
Before submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.