Add new Rails/InBatchesMigrationTransaction cop#1606
Open
bart-westenenk-bex wants to merge 2 commits intorubocop:masterfrom
Open
Add new Rails/InBatchesMigrationTransaction cop#1606bart-westenenk-bex wants to merge 2 commits intorubocop:masterfrom
Rails/InBatchesMigrationTransaction cop#1606bart-westenenk-bex wants to merge 2 commits intorubocop:masterfrom
Conversation
Rails/InBatchesMigrationTransaction cop
5e2c384 to
e21684b
Compare
Introduces Rails/InBatchesMigrationTransaction cop. This will prevent write-locking parts of big (often read heavy) tables during a data migration that is performed with an online application.
e21684b to
4b1ee96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new cop enforces the use of
disable_ddl_transaction!when a migration usesin_batchesto go over a lot of records.In general, when you use
in_batcheswithin a transaction you will negate the effect of usingin_batchesand when deploying the migration you will put a full write lock on the full relation instead of the batched version of it.Since you must always check yourself if it is sensible to use
disable_ddl_transaction!, I have not implemented an autocorrector for this cop.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.in_batcheswithoutdisable_ddl_transactionrails-style-guide#377