[Fix #1612] Add Rails/ActiveStorageAttachedDependent cop#1613
Open
melody-universe wants to merge 1 commit into
Open
[Fix #1612] Add Rails/ActiveStorageAttachedDependent cop#1613melody-universe wants to merge 1 commit into
Rails/ActiveStorageAttachedDependent cop#1613melody-universe wants to merge 1 commit into
Conversation
Flags `has_one_attached` / `has_many_attached` declarations whose `dependent:` value silently no-ops in ActiveStorage. Rails stores the kwarg on the reflection, but only the consumer `ActiveStorage::Attachment#purge_dependent_blob_later` reads it, and only with strict equality on `:purge_later`. Anything else (`true`, `nil`, `:destroy`, arbitrary symbols) leaves orphan blobs in storage when the parent record is destroyed. The cop does not autocorrect — every value other than `:purge_later` and `false` is runtime-equivalent (all silent no-ops), so the right replacement depends on the user's intent. `dependent: :purge` is reported at warning severity, citing rails/rails#36423. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Could you first propose this style to the style guide? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR and its preceding issue were written with some heavy assistance from Claude, but I have personally reviewed and edited both.
Adds
Rails/ActiveStorageAttachedDependent, a new cop that flagshas_one_attached/has_many_attacheddeclarations whosedependent:value silently no-ops in ActiveStorage.Rails stores the kwarg on the reflection, but only the consumer
ActiveStorage::Attachment#purge_dependent_blob_laterreads it back, and only with strict equality on:purge_later. Anything else (true,nil,:destroy, arbitrary symbols) leaves orphan blobs in storage when the parent record is destroyed.The cop does not autocorrect: every offending value is runtime-equivalent (all silent no-ops against the strict
== :purge_latercheck), so the right replacement depends on the user's intent.dependent: :purgeis reported at warning severity per-offense, citing rails/rails#36423.See #1612 for the full motivation, including a real-world example.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.