Fix Rails/StrongParametersExpect to allow safe navigation operator on optional params#1629
Merged
koic merged 1 commit intoMay 25, 2026
Conversation
Member
|
@lucasmazza This looks good to me. Can you squash your commits into one? |
… optional params `&.` is semantically equivalent to `|| nil` — both communicate that the developer expects the param may be absent. The cop already exempted `||` parent nodes via `or_type?`; this adds the same guard for `csend_type?` (safe navigation receiver). Without this fix, `params[:key]&.downcase` is autocorrected to `params.expect(:key).downcase`, silently changing behavior: a missing param goes from returning `nil` to raising `ActionController::ParameterMissing` (400). The developer used `&.` precisely to handle the nil case — the autocorrect removes that intent. The guard is scoped to `parent.receiver == node` so `Model&.find(params[:id])` (where `params[:id]` is an argument, not the receiver of the safe navigation) is still correctly flagged.
ccf0373 to
0ea9fbc
Compare
Contributor
Author
|
@koic done |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
&.is semantically equivalent to|| nil— both communicate that the developer expects the param may be absent. The cop already exempts||parent nodes viaor_type?; this adds the same guard forcsend_type?(safe navigation receiver).Without this fix,
params[:key]&.downcaseis autocorrected toparams.expect(:key).downcase, silently changing behavior: a missing param goes from returningnilto raisingActionController::ParameterMissing(400). The developer used&.precisely to handle the nil case — the autocorrect removes that intent.The guard is scoped to
parent.receiver == nodesoModel&.find(params[:id])(whereparams[:id]is an argument, not the receiver of the safe navigation) is still correctly flagged.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.