[Fix #1630] Fix a false positive in Rails/StrongParametersExpect#1631
Merged
koic merged 1 commit intoMay 26, 2026
Conversation
…ect` This PR fixes a false positive in `Rails/StrongParametersExpect` when negating `params[:key]` with `!`, such as `!params[:key]` or `condition && !params[:key]`. Negating `params[:key]` is a way of checking for an optional parameter, where a missing value is expected and should be falsy. Rewriting `!params[:key]` to `!params.expect(:key)` changes the runtime behavior, because `params.expect(:key)` raises `ActionController::ParameterMissing` when the parameter is absent instead of returning a falsy value. Fixes rubocop#1630.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a false positive in
Rails/StrongParametersExpectwhen negatingparams[:key]with!, such as!params[:key]orcondition && !params[:key].Negating
params[:key]is a way of checking for an optional parameter, where a missing value is expected and should be falsy. Rewriting!params[:key]to!params.expect(:key)changes the runtime behavior, becauseparams.expect(:key)raisesActionController::ParameterMissingwhen the parameter is absent instead of returning a falsy value.Fixes #1630.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.