Conversation
When a pull request was opened, we would previously run all CI twice - once for the `push` event when the branch is pushed up, and once for the `pull_request` event when the PR is opened. Now we will run CI only once when the PR is opened (or re-opened, or "synchronized" which I assume is when you push new changes). And we will run CI for the master branch when a PR is merged. Some repositories configure CI to run _only_ on the `push` event, but that doesn't work when making changed on a forked repository.
At least until we add a Rakefile
We would like to configure branch protection rules, so that a PR cannot be merged without CI passing. But configuring which checks need to pass can be tedious when adding and removing Ruby versions. But by adding one job that validates the success of the matrix, it becomes simple.
Contributor
Author
|
cc @ydah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger GitHub Actions on fewer events
When a pull request was opened, we would previously run all CI twice – once for the
pushevent when the branch is pushed up, and once for thepull_requestevent when the PR is opened.Now we will run CI only once when the PR is opened (or re-opened, or "synchronized" which I assume is when you push new changes). And we will run CI for the master branch when a PR is merged.
Some repositories configure CI to run only on the
pushevent, but that doesn't work when making changed on a forked repository.Cache the gem installation on CI
Add job to validate success of matrix
We would like to configure branch protection rules, so that a PR cannot
be merged without CI passing. But configuring which checks need to pass
can be tedious when adding and removing Ruby versions. But by adding one
job that validates the success of the matrix, it becomes simple.
TODO