Open
Conversation
leitzler
approved these changes
Dec 22, 2022
Member
leitzler
left a comment
leitzler
left a comment
There was a problem hiding this comment.
Just a question, otherwise LGTM
rubrik_polaris/compute/vsphere.py
Outdated
| num_unmatched_criteria -= 1 | ||
| if match_all and num_unmatched_criteria == 0: | ||
| object_ids.append(instance['id']) | ||
| elif not match_all and num_criteria > num_unmatched_criteria >= 1: |
Member
There was a problem hiding this comment.
Is the intent of num_criteria > num_unmatched_criteria >= 1 to return False when we match all criteria? (i.e. if we have match_all = False, num_criteria = 5 and matches them all num_unmatched_criteria = 0) ?
My impression was that it would be enough to match a single criteria to append when match_all = False, i.e. drop the >= 1:
elif not match_all and num_criteria > num_unmatched_criteria:
Member
Author
There was a problem hiding this comment.
I just ripped all of that out, since we implemented filtering in the resolver now. Take another look. Way simpler.
leitzler
reviewed
Jan 2, 2023
| """ | ||
| try: | ||
| query_name = "compute_vmware_vsphere" | ||
| query_name = "compute_vmware_vsphere_list" |
Member
There was a problem hiding this comment.
This query file is missing, forgot to commit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.