Skip to content

Bump action_text-trix from 2.1.15 to 2.1.16#110

Merged
sorah merged 1 commit intomasterfrom
dependabot/bundler/action_text-trix-2.1.16
Feb 13, 2026
Merged

Bump action_text-trix from 2.1.15 to 2.1.16#110
sorah merged 1 commit intomasterfrom
dependabot/bundler/action_text-trix-2.1.16

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Dec 31, 2025

Bumps action_text-trix from 2.1.15 to 2.1.16.

Release notes

Sourced from action_text-trix's releases.

v2.1.16

Security

  • Attachment href attributes are now validated using DOMPurify.isValidAttribute() before rendering as anchor tags. @​flavorjones

Added

  • New .editorElements and .editorElement properties have been added to <trix-toolbar> elements for accessing associated <trix-editor> elements. @​seanpdoyle #1127
  • <trix-editor> elements can now function without an associated <input type="hidden"> element when using ElementInternals. This is configured by setting willCreateInput = false in the before-trix-initialize event and using the [name] attribute for form submissions. @​seanpdoyle #1128
  • Alt text can now be set on attachment preview images via attachment.setAttributes({ alt: "..." }) in trix-attachment-add event handlers. @​seanpdoyle #1198
  • Attachment preview URLs can be customized using the new setPreviewURL() and getPreviewURL() methods on ManagedAttachment, accessible from event handlers. @​seanpdoyle #1210
  • A new trix-before-render event is dispatched before rendering, with a customizable render property for advanced use cases like morph-style rendering integration. @​seanpdoyle #1252
  • When no associated <input> element is present, HTML content within <trix-editor> tags is now safely sanitized and loaded as the initial editor value. @​seanpdoyle #1253

New Contributors

Full Changelog: basecamp/trix@v2.1.15...v2.1.16

Commits
  • 5c8b688 v2.1.16
  • 73c20cf Fix XSS vulnerability in attachment href rendering
  • 07a5e47 Make "yarn version" commit changes to the ruby gem, too
  • 1771514 Merge pull request #1271 from basecamp/flavorjones/ci-sauce-labs
  • 04f803e ci: stabilize Sauce Labs with SC5 tunnel
  • 93f5270 Merge pull request #1270 from basecamp/flavorjones/fix-minitest-errors
  • 31045c9 action_text-trix: pin minitest to < 6
  • 13eebda yarn build
  • 696643d Merge pull request #1269 from basecamp/flavorjones/revert-mousedown-click-change
  • 42f69dd Revert "Toolbar Button: Handle click instead of mousedown"
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 31, 2025
Comment thread Gemfile.lock
remote: https://rubygems.org/
specs:
action_text-trix (2.1.15)
action_text-trix (2.1.16)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The update to minitest to version 6.0.1 is incompatible with the project's current Rails version (8.1.1), which will break the test suite.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The pull request upgrades minitest to version 6.0.1. However, the application is running on Rails 8.1.1, which is known to be incompatible with Minitest 6.x due to significant backward-incompatible changes in the testing library. This incompatibility will cause the test suite to fail to run, often reporting "0 runs, 0 assertions," which will break the CI/CD pipeline and prevent validation of future code changes. Although the project uses RSpec, Rails' internal test infrastructure still relies on minitest as a transitive dependency.

💡 Suggested Fix

To resolve this incompatibility, upgrade the Rails version in the Gemfile to at least 8.1.2, which is compatible with Minitest 6.x. Alternatively, revert the minitest upgrade to a version compatible with Rails 8.1.1, such as ~> 5.26.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: Gemfile.lock#L4

Potential issue: The pull request upgrades `minitest` to version 6.0.1. However, the
application is running on Rails 8.1.1, which is known to be incompatible with Minitest
6.x due to significant backward-incompatible changes in the testing library. This
incompatibility will cause the test suite to fail to run, often reporting "0 runs, 0
assertions," which will break the CI/CD pipeline and prevent validation of future code
changes. Although the project uses RSpec, Rails' internal test infrastructure still
relies on `minitest` as a transitive dependency.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8078773

@sorah
Copy link
Copy Markdown
Member

sorah commented Feb 13, 2026

@dependabot rebase

@sorah sorah enabled auto-merge February 13, 2026 17:05
@dependabot dependabot bot force-pushed the dependabot/bundler/action_text-trix-2.1.16 branch from 4965154 to 14f2e2a Compare February 13, 2026 17:05
@sorah
Copy link
Copy Markdown
Member

sorah commented Feb 13, 2026

@dependabot rebase

Bumps [action_text-trix](https://github.com/basecamp/trix) from 2.1.15 to 2.1.16.
- [Release notes](https://github.com/basecamp/trix/releases)
- [Commits](basecamp/trix@v2.1.15...v2.1.16)

---
updated-dependencies:
- dependency-name: action_text-trix
  dependency-version: 2.1.16
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/action_text-trix-2.1.16 branch from 14f2e2a to 2138a2b Compare February 13, 2026 17:33
@sorah sorah added this pull request to the merge queue Feb 13, 2026
Merged via the queue into master with commit 89f8319 Feb 13, 2026
1 check passed
@sorah sorah deleted the dependabot/bundler/action_text-trix-2.1.16 branch February 13, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant