Fix FrameInfo#block_identifier #1137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ruby 3.4, not all cases match BLOCK_LABL_REGEXP anymore This fixes for those cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This provides a fix for #1134
Beginning with ruby 3.4, not all cases match the
BLOCK_LABL_REGEXPregex (/\Ablock( \(\d+ levels\))* in (.+)\z/) anymore. This pull request fixes for cases whenlocation.label(Thread::Backtrace::Location#label, implemented in ruby'svm_backtrace.csource file; see here) returns e.g. the string"Kernel#loop", which won't match the regex and crahes the app.The change seems to have been introduced in Ruby here: ruby/ruby@61819c8#diff-cf27dccd423ca45138f1278ea6ce04558360203e869cc1fb1608047c606f29d0R195-R202 so I think it makes sense to handle those cases from now on.
See my comment in the original issue #1134 (comment) for a snippet that breaks. Without the fix, it would crash. With the fix, it shows up like this: