Skip to content

feat(ancestry): Update types for v5.0 #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 3 commits into from
Apr 30, 2026
Merged

feat(ancestry): Update types for v5.0 #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a55d55a
feat(ancestry): Add Ancestry::VERSION
sanfrecce-osaka Apr 30, 2026
1dd3a7a
feat(ancestry): Remove apply_orphan_strategy from v5.0
sanfrecce-osaka Apr 30, 2026
80aa340
feat(ancestry): Allow `Symbol` in the `ancestry_column` of `construct…
sanfrecce-osaka Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gems/ancestry/4.3/ancestry.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
module Ancestry
VERSION: String

type depth_options = Hash[:before_depth | :to_depth | :at_depth | :from_depth | :after_depth, Integer]

def self.default_update_strategy: () -> (:sql | :ruby)
Expand Down
2 changes: 2 additions & 0 deletions gems/ancestry/5.0/ancestry.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
module Ancestry
VERSION: String

type depth_options = Hash[:before_depth | :to_depth | :at_depth | :from_depth | :after_depth, Integer]

def self.default_update_strategy: () -> (:sql | :ruby)
Expand Down
2 changes: 0 additions & 2 deletions gems/ancestry/5.0/ancestry/instance_methods.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ module Ancestry

def update_descendants_with_new_ancestry: () -> void

def apply_orphan_strategy: () -> void

def apply_orphan_strategy_rootify: () -> void

def apply_orphan_strategy_destroy: () -> void
Expand Down
2 changes: 1 addition & 1 deletion gems/ancestry/5.0/ancestry/materialized_path.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ module Ancestry

def concat: (*String args) -> String

def self.construct_depth_sql: (String table_name, String ancestry_column, String ancestry_delimiter) -> String
def self.construct_depth_sql: (String table_name, String | Symbol ancestry_column, String ancestry_delimiter) -> String

private

Expand Down
2 changes: 1 addition & 1 deletion gems/ancestry/5.0/ancestry/materialized_path2.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module Ancestry

def generate_ancestry: (Array[PrimaryKey]? ancestor_ids) -> String

def self.construct_depth_sql: (String table_name, String ancestry_column, String ancestry_delimiter) -> String
def self.construct_depth_sql: (String table_name, String | Symbol ancestry_column, String ancestry_delimiter) -> String

private

Expand Down