Skip to content

Normalize path-like objects before retaining the store filename #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu merged 3 commits into from
Sep 5, 2026
Merged

Normalize path-like objects before retaining the store filename #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49217b1
Normalize path-like objects before retaining the store filename
OskarEichler Aug 27, 2026
a937e6c
test: cover PStore regression
OskarEichler Aug 28, 2026
9239a07
Merge branch 'master' into codex/coerce-file-path
nobu Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pstore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ def initialize(file, thread_safe = false)
if File::exist? file and not File::readable? file
raise PStore::Error, format("file %s not readable", file)
end
@filename = file
@filename = File.path(file)
@abort = false
@ultra_safe = false
@thread_safe = thread_safe
Expand Down
11 changes: 11 additions & 0 deletions test/test_pstore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
require 'test/unit'
require 'pstore'
require 'tmpdir'
require 'pathname'

class PStoreTest < Test::Unit::TestCase
def setup
Expand Down Expand Up @@ -296,4 +297,14 @@ def test_interrupted_atomic_save_removes_temporary_file
File.define_singleton_method(:new, original_new) if original_new
Dir.glob("#{@pstore_file}.tmp.*").each { |path| File.unlink(path) rescue nil }
end

def test_path_like_filename_is_normalized
store = PStore.new(Pathname(@pstore_file))
store.ultra_safe = true
store.transaction { store[:foo] = "bar" }

assert_instance_of(String, store.path)
assert_equal(@pstore_file, store.path)
assert_equal("bar", store.transaction(true) { store[:foo] })
end
end