Skip to content

Do not treat truncated read-only stores as empty files #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu merged 3 commits into from
Sep 5, 2026
+10 −0
Merged

Do not treat truncated read-only stores as empty files #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
587481b
Do not treat truncated read-only stores as empty files
OskarEichler Aug 27, 2026
84173c3
test: cover PStore regression
OskarEichler Aug 28, 2026
8463e39
Merge branch 'master' into codex/reject-truncated-readonly-store
nobu Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/pstore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,7 @@ def load_data(file, read_only)
table = load(file)
raise Error, "PStore file seems to be corrupted." unless table.is_a?(Hash)
rescue EOFError
raise unless file.size == 0
# This seems to be a newly-created file.
table = {}
end
Expand Down
9 changes: 9 additions & 0 deletions test/test_pstore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,15 @@ def clear_store
def second_file
File.join(Dir.tmpdir, "pstore.tmp2.#{Process.pid}")
end

def test_truncated_read_only_store_is_not_empty
@pstore.transaction { @pstore[:foo] = "bar" }
data = File.binread(@pstore_file)
File.binwrite(@pstore_file, data.byteslice(0, data.bytesize - 1))

assert_raise(EOFError) { @pstore.transaction(true) { @pstore[:foo] } }
end

def test_store_operations_require_transaction_owner
ready = Thread::Queue.new
release = Thread::Queue.new
Expand Down