Compare RBS strings as binary data - #3110
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: compare equal-length internal strings as binary data so embedded NUL bytes cannot hide a later difference.\n\nReproduction: two equal-length record keys differing after an embedded NUL collapse into one before this change. The focused native-parser model retains both after the change.\n\nVerification: focused baseline/fixed model, combined RBS 4.2.0 consumer models, native hash model, and RuboCop (738 files, zero offenses).\n\nCompatibility: no API or format change; ordinary strings retain existing behavior. No tests are added in this PR.