Fix bundle outdated --groups to actually group output#9699
Open
nevinera wants to merge 2 commits into
Open
Conversation
print_indented unconditionally sorted table rows by gem name, discarding the group clustering that --groups had already computed, so --groups produced output identical to plain outdated (ruby#9333). Skip that re-sort when a --group/--groups option is active, since specs_for_outdated_check already sorts by name and group_by preserves that order within each group. Also fixes the outdated_spec.rb "--groups" test, which previously passed regardless of whether grouping worked because its expected output happened to match alphabetical-by-name ordering.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes bundle outdated --groups so the output is actually grouped by Bundler group, instead of being re-sorted alphabetically by gem name at print time (which previously erased the grouping computed earlier).
Changes:
- Add an optional
sortparameter toprint_indentedto allow callers to skip row re-sorting. - When
--groups/--groupis active, print the gems table without re-sorting so group clustering is preserved. - Strengthen the existing
--groupsspec to fail more reliably by adding another outdated gem in the same non-default group.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/commands/outdated_spec.rb | Updates the --groups expectation to assert true group clustering by introducing an additional gem in the same group. |
| lib/bundler/cli/outdated.rb | Skips the print-time sort when group-based output is requested, preserving the pre-grouped ordering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update
bundle outdated --groupsto produce its table of output actually sorted by group.Analysis
print_indentedunconditionally sorted table rows by gem name, discarding the group clustering that --groups had already computed, so --groups produced output identical to plain outdated (#9333). Skip that re-sort when a --group/--groups option is active, since specs_for_outdated_check already sorts by name and group_by preserves that order within each group.What was the end-user or developer problem that led to this PR?
A (correct) observation in #9333 that
bundle outdated --groupswas not actually grouping at all.What is your fix for the problem, implemented in this PR?
sort = truesecond positional parameter toprint_indented!, which controls whether to sort its results before printingprint_gems_table, determine whether to sort based on theoptions_include_groupsattr, which is true if--groupsor--group foois supplied.Make sure the following tasks are checked