Clarify requirement marshal validation#9711
Merged
Merged
Conversation
Stop using assignment as an always-true condition while preserving legacy normalization of requirement operators. Make the validation flow easier to follow.
hsbt
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
There was no end-user-facing bug.
The validation relied on an assignment expression being truthy, which made the intent unclear and could easily be mistaken for an accidental assignment.
What is your fix for the problem, implemented in this PR?
Separate the normalization assignment from the validation condition so that the intent of each operation is explicit.
Make sure the following tasks are checked