Fail bundle check when frozen mode needs lockfile changes#9715
Open
hsbt wants to merge 1 commit into
Open
Conversation
`BUNDLE_FROZEN=1 bundle check` reported that dependencies are satisfied and exited 0 even when the lockfile was missing CHECKSUMS entries, because `write_lock` only warns in frozen mode. Run the same frozen validation as `bundle install` so `bundle check` fails consistently. #9546 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hsbt
force-pushed
the
claude/rubygems-issue-9546-9c100e
branch
from
July 23, 2026 01:55
5e232ce to
07337df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUNDLE_FROZEN=1 bundle checkprinted "The Gemfile's dependencies are satisfied" and exited 0 even when the lockfile was missing a CHECKSUMS entry, because the check command never ran the frozen validation andwrite_lockonly warns in frozen mode. This makesbundle checkcallensure_equivalent_gemfile_and_lockfilelikebundle installdoes, so it now fails with the same message and exit status 16. The dedicated branch for frozen mode without a lockfile is removed sincevalidate_platforms!raised first and made it unreachable. Running the frozen validation beforevalidate_runtime!also improves that case to report "Frozen mode is set, but there's no lockfile".Fixes #9546