Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change button from 'Promote to Admin' to 'Edit User' #4701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change button from 'Promote to Admin' to 'Edit User' #4701

wants to merge 1 commit into from

Conversation

leslie-seeberger
Copy link

Resolves #4664

Description

Changed the 'Promote to Admin' button to 'Edit User', allowing the super admin to change the user's role from the admin/users/edit page.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Added a test to ensure that the super admin has the 'Edit User' button for the organization's user, and that clicking it will take them to the correct page.
  • Manually tested

Screenshot from 2024-10-02 23-58-00

cielf
cielf reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good

@cielf cielf requested a review from dorner October 4, 2024 16:14
@cielf
Copy link
Collaborator

cielf commented Oct 4, 2024

@dorner Can you take a technical pass on this one, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cielf cielf cielf left review comments

@dorner dorner Awaiting requested review from dorner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@leslie-seeberger @cielf