5021 - Fixed break of list items on validation of new barcode item#5045
Merged
dorner merged 1 commit intorubyforgood:mainfrom Mar 21, 2025
Merged
Conversation
Naraveni
force-pushed
the
5021-FIX-NEW-BARCODE-LIST-ON-VALIDATE
branch
2 times, most recently
from
b984d0f to
79c9829
Compare
dorner
requested changes
Feb 28, 2025
Collaborator
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Can you please replace the controller spec with a request spec? That's the recommended approach for this.
Naraveni
force-pushed
the
5021-FIX-NEW-BARCODE-LIST-ON-VALIDATE
branch
from
78e2c5d to
c370307
Compare
Naraveni
force-pushed
the
5021-FIX-NEW-BARCODE-LIST-ON-VALIDATE
branch
from
60f9b7d to
addf11e
Compare
Contributor
Author
|
@dorner could you please have a look at this. |
Naraveni
force-pushed
the
5021-FIX-NEW-BARCODE-LIST-ON-VALIDATE
branch
from
addf11e to
4056841
Compare
Contributor
|
@Naraveni: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5021
Description
List Items was breaking on validation of new barcode item
Type of change
How Has This Been Tested?
I wrote test cases to make sure thar item list is available on validation.