-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Units / Packs fixes #5099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"First Thing" from the issue is still going BOOM!
@cielf I had previously fixed the wrong bug, sorry! Please try again :) Now also:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more things....
1/ I just thought to test this -- you should not be able to enter unit as a custom unit, right? I don't know that it would break anything, but it's going to be confusing.
2/ Units is capitalized in the dropdown in request, and should not be.
Haven't tested the name with units issue live yet, but will.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me, functionally (Good enough for our beta tester). Over to @dorner for technical comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking comment. This is good to merge!
@awwaiid can you look at the failing tests? I tried rerunning but they're still failing. |
Change style of conditional to be more cleaner Co-authored-by: Daniel Orner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Sall good. We'll need to add enable_packs to flipper for prod/staging, and turn it on for staging - but those staging changes can be a separate PR.
Fixes for #5096