Conversation
| end | ||
| end | ||
| end | ||
| it "dropdown menu does not show My Co-Workers" do |
There was a problem hiding this comment.
Can you please change this into a request test? System tests are only needed for tests that require interactivity.
Also, please remove the puts statements.
There was a problem hiding this comment.
For sure, I'll make those changes and get back to you.
There was a problem hiding this comment.
Oh boy, I hope I did this right. The gits and commits and pushes and merges get me all jumbled up.
I ended up creating a new request testing file for the user dropdown. Actually remembered to run the lint this time too, which passed with 0 offenses. The only tests that failed are the tests that I think are failing for everyone at the moment? Not sure what's normal, but they seemed completely irrelevant to what I was working on.
|
Lint is failing as well. |
|
Lint is still failing. |
nolanborz
force-pushed
the
5000-remove-mycoworkers-from-org-user-dropdown
branch
from
5011963 to
6a179fc
Compare
|
Please ignore the force. My most recent commit 96ae98e is the correct one. I sincerely apologize for the train wreck of a PR, cracked a little under the pressure trying to check and make sure I had done everything correctly. |
|
@nolanborz: Your PR |
3 participants
Checklist:
yes - I have performed a self-review of my own code,
yes - I have commented my code, particularly in hard-to-understand areas,
yes - I have made corresponding changes to the documentation,
yes - I have added tests that prove my fix is effective or that my feature works,
yes - New and existing unit tests pass locally with my changes ("bundle exec rake"),
yes - Title include "WIP" if work is in progress.
yes - I acknowledge that I will not force push my branch once reviews have started.
-->
Resolves #5000
Description
Hid the "My Co-Workers" item from the top-right dropdown for 'banks/org' users by adding an additional 'if' statement in the views/layouts/_lte_navbar.html.erb file to check if the user is a partner or not.
Type of change
How Has This Been Tested?
I added an rspec test which checks that "My Co-Workers" is not visible for org users after clicking on the top-right button. I added it to the most appropriate place I could find, spec/system/navigation_system_spec.rb. If we want to add more tests for the top-right dropdown menu we would probably add a new file, but it seemed out of the scope of this issue.
All tests passed.
Screenshots