Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5102 - 500 error on empty target_date on storage_locations#show #5111

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

wjwb-uk
Copy link
Contributor

@wjwb-uk wjwb-uk commented Mar 20, 2025

Resolves #5102

Description

storage_locations#show modified to handle empty string passed as param for version_date
Added test for empty string passed as param into above request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Reproduced as per issue, and resolved with automated test to confirm fix.

Fix implimented in storage_locations_controller.rb
@wjwb-uk wjwb-uk changed the title 5102 - Added Failing Test to storage_locations_requests_spec.rb 5102 - 500 error on empty target_date on storage_locations#show Mar 20, 2025
@cielf
Copy link
Collaborator

cielf commented Mar 20, 2025

Thanks @wjwb-uk - LGTM from a functional pov. Passing to @awwaiid or @dorner for a quick technical look.

@cielf cielf requested review from dorner and awwaiid March 20, 2025 14:44
@dorner dorner merged commit c5601ef into rubyforgood:main Mar 21, 2025
11 checks passed
@dorner
Copy link
Collaborator

dorner commented Mar 21, 2025

Thanks!

Copy link
Contributor

@wjwb-uk: Your PR 5102 - 500 error on empty target_date on storage_locations#show is part of today's Human Essentials production release: 2025.03.23.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blanking the date on storage location view makes it fail. Fix it.
3 participants