Fix persistence and timing problems with tests #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try to run full test locally. But I think more important is what we can see during CI run |
| @@ -43,7 +43,9 @@ | |||
| context "when sorting" do | |||
| it "displays users in the selected order" do | |||
| select "By least recently added", from: "search_order" | |||
| expect(page).to have_text(/#{admin.email}.+#{martin.email}.+#{rosemary.email}/m) | |||
| Capybara.using_wait_time(7) do | |||
There was a problem hiding this comment.
Is there something that can take 7 seconds to load search results when we have only several users in the DB?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed? And Why Did It Change?
This adds database_cleaner and adds a delay to a test that was running fine on its own but was failing when all tests were run.
This fixes the tests locally for me, but I'm curious whether anyone else was encountering these problems. If not, then perhaps there is something particular to my setup that needs to be fixed.