Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "the" before gem references in owner notification emails #5520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcoroth
Copy link

While receiving notifications about gem ownership, I noticed the wording felt a bit unnatural without the definite article "the" before references to gems. This small pull request improves readability by adding "the" where appropriate in the owner-related email notifications.

Just a small grammar improvement that, I think, makes the notifications sound more natural. Feel free to close this pull request if you disagree 🙈

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (46ff0a3) to head (8707cbe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5520      +/-   ##
==========================================
- Coverage   97.11%   94.33%   -2.79%     
==========================================
  Files         454      454              
  Lines        9441     9500      +59     
==========================================
- Hits         9169     8962     -207     
- Misses        272      538     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcoroth marcoroth force-pushed the locales-owner-wording branch from df7f612 to 3dd4315 Compare March 11, 2025 03:27
@simi simi force-pushed the locales-owner-wording branch from 3dd4315 to 8707cbe Compare April 1, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants