Fix reverse dependencies by using distinct #5566
Open
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5566 +/- ##
===========================================
+ Coverage 71.71% 94.35% +22.63%
===========================================
Files 453 453
Lines 9609 9470 -139
===========================================
+ Hits 6891 8935 +2044
+ Misses 2718 535 -2183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm a bit concerned if this will have a performance impact, can you share the generated queries and I can explain analyze them? |
I'll check. |
simi
reviewed
Mar 31, 2025
| @@ -9,6 +9,8 @@ def index | |||
| @reverse_dependencies = @rubygem.reverse_dependencies | |||
| .by_downloads | |||
| .preload(:gem_download, :latest_version) | |||
| .distinct(:id) | |||
There was a problem hiding this comment.
Why is :id needed? Seems distinct supports only true/false arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix reverse dependencies bug
Another example: https://rubygems.org/gems/rspec/reverse_dependencies
Description
Reverse dependencies are being repeated.
Linked issue: #5199
Tried to solve this at least in the user facing controller side of things.