Skip to content

Conversation

@halostatue
Copy link
Contributor

No description provided.

@halostatue
Copy link
Contributor Author

Note that this includes #286 because of the regression involved, plus this is something that was ultimately commented out of the other Rails 5 branch.

@seanhandley
Copy link

Note that Rails needs Ruby 2.2.0 or greater, hence the Travis failures here.

See rails/rails@32f7491#diff-73ac7236f7a8247a9cd61d338ef49cda

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have to update this to 5.0.0.beta1.

@BenMorganIO
Copy link
Collaborator

Maybe drop support for 2.0 and 2.1 for this gem? I think that would be a good idea since rails is moving to the 2.2 area and this is largely a rails gem.

@halostatue
Copy link
Contributor Author

I’m fine with any direction on this. IMO, the way to fix the tests would be to switch to multiple Gemfiles rather than using an ENV setting, because I’m not sure that you can exclude from a Travis test matrix based on the ENV setting.

@jhawthorn
Copy link
Collaborator

We can skip older versions of ruby with rails 5 using the exclude matrix feature of CircleCI. https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix

Ideally I'd like to keep compatibility with older versions of ruby unless there's a compelling reason to drop it.

@halostatue
Copy link
Contributor Author

Cool. Apparently you can have the ENV be part of the exclusion. I will update the travis.yml to reflect this.

@lstrzebinczyk
Copy link

Is there any chance to push this? Updating paranoia is blocking me from updating to 5.0.0, and issue seems to be with travis settings, not anything with the code.

@halostatue
Copy link
Contributor Author

Unless someone else wants to pick this up, I should be able to finalize the matrix for this on the weekend.

@lstrzebinczyk
Copy link

@halostatue Any progress?

@jhawthorn
Copy link
Collaborator

Thanks for the work! This was cherry-picked with modifications into master, which should now support rails 5.

@jhawthorn jhawthorn closed this Feb 3, 2016
@halostatue halostatue deleted the rails5 branch February 3, 2016 18:19
@seanhandley
Copy link

Nice one @jhawthorn

@seanhandley
Copy link

Is a release coming soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants