Fix a call to nil on objects to destroy #475
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a model has no :dependent option in their association, this is nil. `target.send(options[:dependent])` will fail in this case.
Shigawire
changed the title
mathieujobin
requested changes
Mar 23, 2022
Collaborator
mathieujobin
left a comment
mathieujobin
left a comment
There was a problem hiding this comment.
Can you please add a test case to reproduce the problem this fixes ?
thanks
Collaborator
|
revisiting this... I really would like to see a test that reproduce the problem without the patch... Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a model has no :dependent option in their association, this is nil.
target.send(options[:dependent])will fail in this case.