Skip to content

Revert trailing slash change#496

Merged
rdimaio merged 1 commit intorucio:mainfrom
voetberg:trailing-slash-fix
Mar 20, 2025
Merged

Revert trailing slash change#496
rdimaio merged 1 commit intorucio:mainfrom
voetberg:trailing-slash-fix

Conversation

@voetberg
Copy link
Copy Markdown
Contributor

The trailing slash removal causes pages to break when refreshed or directly linked to - any hyperlinks in md pages need to work around this.

Copy link
Copy Markdown
Contributor

@rdimaio rdimaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break the daemon pages, though? I wonder why it was introduced in the first place

@voetberg
Copy link
Copy Markdown
Contributor Author

It doesn't, at least not on local (we need to make a doc dev build site or something....), so I'm not sure. @Soap2G Why did you add this setting?

@Soap2G
Copy link
Copy Markdown
Contributor

Soap2G commented Mar 17, 2025

It doesn't, at least not on local (we need to make a doc dev build site or something....), so I'm not sure. @Soap2G Why did you add this setting?

Hi @voetberg, this was the reason: #492

@Soap2G
Copy link
Copy Markdown
Contributor

Soap2G commented Mar 17, 2025

any hyperlinks in md pages need to work around this.

Also, does this mean that all the links must end with a trailing slash?
On my pc https://rucio.github.io/documentation/ and https://rucio.github.io/documentation are both working..

@voetberg
Copy link
Copy Markdown
Contributor Author

any hyperlinks in md pages need to work around this.

Also, does this mean that all the links must end with a trailing slash? On my pc https://rucio.github.io/documentation/ and https://rucio.github.io/documentation are both working..

I think the base /documentation/ page is an exception, but the trailing slashes (from what I can divine from reading other people's issues on docusaurus) should be dependent on the site hosts' routing instructions (in our case, I believe it is dynamic) but because the slashes are disabled it no longer has a correct url (forces the no trailing slashes option in all cases). I am not wholly satisfied with the the docs explanation of this but I'm fairly sure that's whats happening.

To solve #492 a better solution would be to have absolute links to the daemons (e.x.: /bin/rucio-abacus-account) or to move the bin dir about. I do not think removing trailing slashes solves this problem.

@Soap2G
Copy link
Copy Markdown
Contributor

Soap2G commented Mar 18, 2025

Hi, I see. Then asolute paths are indeed a better solution.
Should I open a separate PR to change those, or can it be done here?

@rdimaio
Copy link
Copy Markdown
Contributor

rdimaio commented Mar 20, 2025

Hi, I see. Then asolute paths are indeed a better solution. Should I open a separate PR to change those, or can it be done here?

I think it's best if we open a separate PR. Let's merge this for now, as most links pointing to the documentation from the outside are currently broken

@rdimaio rdimaio merged commit 773a8be into rucio:main Mar 20, 2025
6 checks passed
@voetberg voetberg deleted the trailing-slash-fix branch December 3, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants