feat: implement handlers for transformation and library #339
+444
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔒 Scanned for secrets using gitleaks 8.28.0
Comment on lines
183
to
189
| req := &transformations.CreateLibraryRequest{ | ||
| Name: newData.Name, | ||
| Description: newData.Description, | ||
| Code: newData.Code, | ||
| Language: newData.Language, | ||
| ExternalID: newData.ID, | ||
| } |
Collaborator
There was a problem hiding this comment.
Generally we don't include externalID in the update request ( you are not allowed to update the externalID by mistake in update call ) and the backend shouldn't accept it. The capability to attach externalID to the backend should be part of create flow.
I would suggest to have separate entities for create and update and keep the model different in terms of externalID.
Contributor
Author
There was a problem hiding this comment.
Validation of externalId to be same as existing was done is backend update call. So used same structs. Sure, will drop externalID
Comment on lines
179
to
185
| req := &transformations.CreateTransformationRequest{ | ||
| Name: newData.Name, | ||
| Description: newData.Description, | ||
| Code: newData.Code, | ||
| Language: newData.Language, | ||
| ExternalID: newData.ID, | ||
| } |
Collaborator
There was a problem hiding this comment.
Same comment as in libraries !
…ndler 🔒 Scanned for secrets using gitleaks 8.28.0
🔒 Scanned for secrets using gitleaks 8.28.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔒 Scanned for secrets using gitleaks 8.28.0
resolves DAW-2749