Skip to content

Conversation

@abhimanyubabbar
Copy link
Collaborator

@abhimanyubabbar abhimanyubabbar commented Jan 16, 2026

Scanned-by: gitleaks 8.30.0

Description

A simple PR which augments the Provider interface with syntactic and semantic rules functions. These functions needs to be implemented by each provider and will be registered in the registry.

Changes

  1. Updated the provider interface with new functions for syntactic rules and semantic rules.
  2. Updated the empty provider and base provider with the implementation.
  3. Updated the composite provider as well mainly with aggregating the rules.

Fixes PR: https://linear.app/rudderstack/issue/DEX-227/add-interface-support-for-syntactic-and-semantic-validation-rules-in

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.07%. Comparing base (c9d019b) to head (dfadb4b).

Files with missing lines Patch % Lines
cli/internal/provider/baseprovider.go 0.00% 12 Missing ⚠️
cli/internal/provider/composite.go 0.00% 12 Missing ⚠️
cli/internal/provider/emptyprovider.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   44.15%   44.07%   -0.08%     
==========================================
  Files         202      202              
  Lines       14242    14270      +28     
==========================================
+ Hits         6288     6290       +2     
- Misses       7377     7404      +27     
+ Partials      577      576       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant