Skip to content

fix: support Facebook SDK 18 and fix $FacebookSDKVersion override #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgupta98 merged 3 commits into from
Jul 6, 2026
Merged

fix: support Facebook SDK 18 and fix $FacebookSDKVersion override #57

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfa45d5
fix: support Facebook SDK 18 and fix $FacebookSDKVersion override
vgupta98 Jul 2, 2026
77868cb
chore: format default Facebook SDK version log for array constraint
vgupta98 Jul 2, 2026
c8e2d64
fix: ignore nil or empty $FacebookSDKVersion override
vgupta98 Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Rudder-Facebook.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ require 'json'

package = JSON.parse(File.read(File.join(__dir__, 'package.json')))

facebook_sdk_version = '~> 17.0.2'
facebook_sdk_version = ['>= 17.0.2', '< 19.0']
rudder_sdk_version = '~> 1.12'
deployment_target = '12.0'
facebook_app_events = 'FBSDKCoreKit'
Expand All @@ -25,11 +25,11 @@ Pod::Spec.new do |s|
s.source_files = 'Rudder-Facebook/Classes/**/*'
s.ios.deployment_target = deployment_target

if defined?($FacebookSDKVersion)
if defined?($FacebookSDKVersion) && !$FacebookSDKVersion.to_s.empty?
facebook_sdk_version = $FacebookSDKVersion
Pod::UI.puts "#{s.name}: Using user specified Facebook SDK version '#{FacebookSDKVersion}'"
Pod::UI.puts "#{s.name}: Using user specified Facebook SDK version '#{$FacebookSDKVersion}'"
else
Pod::UI.puts "#{s.name}: Using default facebook SDK version '#{facebook_sdk_version}'"
Pod::UI.puts "#{s.name}: Using default facebook SDK version '#{Array(facebook_sdk_version).join(', ')}'"
end

if defined?($RudderSDKVersion)
Expand All @@ -40,5 +40,5 @@ Pod::Spec.new do |s|
end

s.dependency 'Rudder', rudder_sdk_version
s.dependency facebook_app_events, facebook_sdk_version
s.dependency facebook_app_events, *Array(facebook_sdk_version)
Comment thread
dciccale marked this conversation as resolved.
end
Loading