feat: add events processing and retry headers #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThis PR makes several updates across the analytics-js-plugins package. Size limits in configuration files have been increased slightly for several CDN and NPM entries. Test cases and source files have been refactored to consolidate multiple retry and timing parameters into a single object (of type Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Client/Test
participant Queue as Queue System
participant Processor as processQueueCb
participant Logger as logErrorOnFailure
Caller->>Queue: Enqueue processing request
Queue->>Queue: Consolidate retry/timing info into QueueProcessCallbackInfo
Queue->>Processor: Call processQueueCb({retryAttemptNumber, maxRetryAttempts, willBeRetried, timeSinceFirstAttempt, timeSinceLastAttempt, reclaimed})
Processor-->>Queue: Return processing result
alt Processing failure
Queue->>Logger: logErrorOnFailure({retryAttemptNumber, maxRetryAttempts, willBeRetried, timeSinceFirstAttempt, timeSinceLastAttempt, reclaimed})
end
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2066 +/- ##
===========================================
+ Coverage 61.42% 61.49% +0.07%
===========================================
Files 478 478
Lines 16407 16433 +26
Branches 3231 3237 +6
===========================================
+ Hits 10078 10106 +28
+ Misses 5140 5138 -2
Partials 1189 1189 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
size-limit report 📦
|
|
koladilip
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I've added retry headers and also the missing "sent at" header for all the requests to the data plane.
Retried-After- Time in seconds since the previous attempt to send the event(s)Retry-Attempt- The retry attempt numberRetried-After-First- Time in seconds since the very first attempt to send the event(s)Reclaimed- Boolean to indicate if the events were reclaimed from the storageLinear task (optional)
https://linear.app/rudderstack/issue/SDK-2996/js-sdk-implementation-retry-headers
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
These improvements aim to boost reliability and maintain smoother analytics operations without altering end-user functionality.