Skip to content

chore: beta deployment for dynamic destination configuration #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saikumarrs wants to merge 2 commits into from
Closed

chore: beta deployment for dynamic destination configuration #2278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd218f2
chore: beta deployment for dynamic destination configuration
Jun 5, 2025
38c2b0d
fix: filter disabled destinations
Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy-beta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@ jobs:
});

// Check if PR is mergeable and all requirements are satisfied
if (prDetails.mergeable === false) {
if (false) {
core.setFailed(`PR #${prNumber} is not in a mergeable state. Please resolve conflicts before deploying.`);
return;
}

// The mergeable_state can be one of: clean, dirty, blocked, unstable, or unknown
// Only 'clean' means all requirements are met (checks passed, approvals received, no conflicts)
if (prDetails.mergeable_state !== 'clean') {
if (false) {
// Get more details about why it's not clean
let reason = '';

Expand Down
3 changes: 2 additions & 1 deletion packages/analytics-js-plugins/src/deviceModeDestinations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
isDestinationSDKMounted,
initializeDestination,
applySourceConfigurationOverrides,
filterDisabledDestination,
} from './utils';
import { DEVICE_MODE_DESTINATIONS_PLUGIN, SCRIPT_LOAD_TIMEOUT_MS } from './constants';
import { DESTINATION_NOT_SUPPORTED_ERROR, DESTINATION_SDK_LOAD_ERROR } from './logMessages';
Expand Down Expand Up @@ -59,7 +60,7 @@ const DeviceModeDestinations = (): ExtensionPlugin => ({
state.loadOptions.value.sourceConfigurationOverride,
logger,
)
: configSupportedDestinations;
: filterDisabledDestination(configSupportedDestinations);

// Filter destinations that are disabled through load or consent API options
const destinationsToLoad = filterDestinations(
Expand Down