Skip to content

feat: add dmt support for cloned destinations #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saikumarrs merged 6 commits into from
Aug 29, 2025
Merged

feat: add dmt support for cloned destinations #2434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cd5c9b
feat: add dmt support for cloned destinations
MoumitaM Jul 10, 2025
147ddf2
Merge branch 'develop' into feature/sdk-3486-add-dmt-support-for-clon…
MoumitaM Aug 11, 2025
0a79668
test: unit tests
MoumitaM Aug 12, 2025
867b0da
Merge branch 'develop' into feature/sdk-3486-add-dmt-support-for-clon…
MoumitaM Aug 12, 2025
161ec16
chore: review comment addressed
MoumitaM Aug 18, 2025
a0c7ef8
Merge branch 'develop' into feature/sdk-3486-add-dmt-support-for-clon…
MoumitaM Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/analytics-js-common/src/types/Destination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ export type DestinationConfig = BaseDestinationConfig & {

export type Destination = {
id: string;
originalId?: string;
displayName: string;
userFriendlyId: string;
shouldApplyDeviceModeTransformation: boolean;
Expand Down
7 changes: 7 additions & 0 deletions packages/analytics-js-plugins/__tests__/deviceModeDestinations/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,9 @@ describe('deviceModeDestinations utils', () => {
// Enabled status should match override
expect(dest1Clones[0]?.enabled).toBe(true);
expect(dest1Clones[1]?.enabled).toBe(true);
// cloned destination should have originalId and originalId should be the original destination id
expect(dest1Clones[0]?.originalId).toBe('dest1');
expect(dest1Clones[1]?.originalId).toBe('dest1');

// dest2 and dest3 should be unchanged
expect(result.find(d => d.id === 'dest3')).toBe(mockDestinations[2]);
Expand All @@ -606,6 +609,7 @@ describe('deviceModeDestinations utils', () => {
expect(dest2Clones[0]).toBeDefined();
expect(dest2Clones[0]?.id).toBe('dest2_1');
expect(dest2Clones[0]?.userFriendlyId).toBe('dest2_friendly_1');
expect(dest2Clones[0]?.originalId).toBe('dest2');

// Config and enabled status should match each override
expect(dest2Clones[0]?.config.apiKey).toBe('cloneA');
Expand Down Expand Up @@ -646,6 +650,9 @@ describe('deviceModeDestinations utils', () => {
expect(dest3Clones[1]?.config?.extra).toBe(123);
expect(dest3Clones[0]?.enabled).toBe(true);
expect(dest3Clones[1]?.enabled).toBe(true);
// cloned destination should have originalId and originalId should be the original destination id
expect(dest3Clones[0]?.originalId).toBe('dest3');
expect(dest3Clones[1]?.originalId).toBe('dest3');
// inherit other config properties
expect(dest3Clones[0]?.config?.eventFilteringOption).toBe('disable');
expect(dest3Clones[1]?.config?.eventFilteringOption).toBe('disable');
Expand Down
Loading
Loading