Skip to content

fix: warehouse jobs skip processing destinations #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/1.47.x
Choose a base branch
from

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Apr 17, 2025

Description

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

@RanjeetMishra RanjeetMishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achettyiitr
Can you explain state of system the moment we update config for skipDestination? Any tasks till upload state will keep doing its work, only at last stage of upload we will keep skipping?

And once this skipDestination list is cleared, it will resume?

@achettyiitr achettyiitr force-pushed the fix.warehouse-skip-processing-destinations branch from 919f50d to 376e332 Compare April 17, 2025 12:57
@achettyiitr
Copy link
Member Author

@achettyiitr Can you explain state of system the moment we update config for skipDestination? Any tasks till upload state will keep doing its work, only at last stage of upload we will keep skipping?

And once this skipDestination list is cleared, it will resume?

Once the config is set, we will not pick any jobs for those destinations. If there are some jobs already being processed, it will continue processing.
Upon removal, jobs from those destinations will be picked up.

@achettyiitr achettyiitr changed the title fix: warehouse skip processing destinations fix: warehouse jobs skip processing destinations Apr 17, 2025
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.01%. Comparing base (b5af4c2) to head (376e332).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.47.x    #5747      +/-   ##
==================================================
+ Coverage           76.98%   77.01%   +0.02%     
==================================================
  Files                 487      487              
  Lines               66244    66257      +13     
==================================================
+ Hits                50997    51025      +28     
+ Misses              12475    12463      -12     
+ Partials             2772     2769       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants