feat: use account to decide oauth type of a destination #5810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5810 +/- ##
==========================================
+ Coverage 76.90% 76.96% +0.05%
==========================================
Files 491 491
Lines 67183 67199 +16
==========================================
+ Hits 51667 51717 +50
+ Misses 12692 12661 -31
+ Partials 2824 2821 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
utsabc
reviewed
May 5, 2025
Comment on lines
+26
to
+28
| if err != nil { | ||
| return false, err | ||
| } |
There was a problem hiding this comment.
Maybe mock misc.NestedMapLookup to throw error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are introducing new way to checking oauth type of a destination. We are using account to detect oauth.
Linear Ticket
https://linear.app/rudderstack/issue/INT-3563/drive-the-oauth-flow-based-on-accounts-information-rather-than
Security