fix: application context for async jobs framework#6709
Open
achettyiitr wants to merge 1 commit intomasterfrom
Open
fix: application context for async jobs framework#6709achettyiitr wants to merge 1 commit intomasterfrom
achettyiitr wants to merge 1 commit intomasterfrom
Conversation
🔒 Scanned for secrets using gitleaks 8.29.1
achettyiitr
commented
Feb 23, 2026
Comment on lines
-86
to
-95
| type Uploader interface { | ||
| Upload(*common.AsyncDestinationStruct) common.AsyncUploadOutput | ||
| UploadBulkFile(ctx context.Context, filePath string) (bool, error) | ||
| PopulateCsvFile(actionFile *ActionFileInfo, streamTraitsMapping []StreamTraitMapping, line string, data Data) error | ||
| } | ||
|
|
||
| type HttpClient interface { | ||
| Do(req *http.Request) (*http.Response, error) | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
These are not being used anywhere. Removing it.
achettyiitr
requested review from
krishna2020,
saikumarrs and
shekhar-rudder
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6709 +/- ##
==========================================
- Coverage 80.05% 80.02% -0.03%
==========================================
Files 566 566
Lines 63335 63331 -4
==========================================
- Hits 50703 50681 -22
- Misses 9637 9652 +15
- Partials 2995 2998 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shekhar-rudder
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 Scanned for secrets using gitleaks 8.29.1
Description
Linear Ticket
Security