fix(error_index): close parquet file after object-storage upload - #7232
Open
Ayush7614 wants to merge 1 commit into
Open
fix(error_index): close parquet file after object-storage upload#7232Ayush7614 wants to merge 1 commit into
Ayush7614 wants to merge 1 commit into
Conversation
uploadPayloads reopened the parquet file for upload but never closed it on success or failure, leaking one FD per error-index flush. Also close the create handle if encode fails before the explicit Close call.
|
Thank you @Ayush7614 for contributing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uploadPayloadsreopened the parquet file for object-storage upload but never closed it on success or failure, leaking one FD per error-index flushClose*os.Filefails afteruploadPayloadsreturns (proves the FD was closed)Test plan
go test ./enterprise/reporting/error_index/ -run 'TestUploadPayloadsClosesFile' -vgo test ./enterprise/reporting/error_index/ -run 'TestWorkerWriter/writer/writes$' -vSecurity