chore: make reporting 413 handling unconditional - #7313
chore: make reporting 413 handling unconditional#7313rudder-devbox[bot] wants to merge 4 commits into
Conversation
|
👋 I'm rudder-devbox. I opened this PR from a Linear ticket. Mention |
|
I checked the failed CI logs and did not find a source failure caused by the reporting change. Root cause from the logs:
I synced the PR branch and confirmed it is already at the pushed head commit |
|
I found and fixed a package-unit test isolation issue. Root cause from the failed log: Fix: Validation:
Pushed commit: f4ca434 |
|
Knowledge distillation completed |
|
I fixed the verify lint failure. Root cause from the lint log: golangci-lint v2.9.0 reported two Fix: updated those stubs to return empty non-nil Validation:
Pushed commit: 5243027 |
|
Knowledge distillation completed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7313 +/- ##
==========================================
+ Coverage 79.34% 79.79% +0.45%
==========================================
Files 609 609
Lines 67963 67978 +15
==========================================
+ Hits 53922 54243 +321
+ Misses 10876 10544 -332
- Partials 3165 3191 +26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Removes the
requestEntityTooLargeHandlingfeature flag from enterprise reporting so graceful HTTP 413 handling is always active for:DefaultReporter.sendMetric)Flusher.sendBatch)ErrorDetailReporter.sendEDMetric)The constructors no longer load
Reporting.requestEntityTooLargeHandling,Reporting.flusher.requestEntityTooLargeHandling, orReporting.errorReporting.requestEntityTooLargeHandling, and tests no longer set the removed flag.Validation:
make -C /workspace/rudder-server fmt— passedgo test -count 1 ./enterprise/reporting ./enterprise/reporting/flusher— passed:ok github.com/rudderlabs/rudder-server/enterprise/reporting 15.459sok github.com/rudderlabs/rudder-server/enterprise/reporting/flusher 25.352srequestEntityTooLargeHandling,Reporting.requestEntityTooLargeHandling,Reporting.flusher.requestEntityTooLargeHandling, andReporting.errorReporting.requestEntityTooLargeHandling— no matches foundgit diff --check— passedLinear Ticket
PIPE-3324
Integration mini verification was skipped because this rudder-server source change is not source-verifiable in the local mini stack; focused Go tests were used as the runnable validation surface.
Broader
go test -count 1 ./enterprise/reporting/...failed in the unrelatedenterprise/reporting/error_indexpackage. Observed failures includedTestErrorIndexReporter/sync_datatiming out its condition and multipleTestWorkerWritercases failing because DuckDB could not download theparquetextension due HTTP 403 fromhttp://extensions.duckdb.org/v1.5.4/linux_amd64/parquet.duckdb_extension.gz. The directly touched packages passed.Security