Skip to content

Refactor PR checks #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rudnerbjoern merged 1 commit into from
Jun 26, 2025
Merged

Refactor PR checks #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 25 additions & 14 deletions .github/workflows/combine-schema.v3.2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,32 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Wait for required status check to pass

- name: Wait for PR checks (ignore error if none)
id: check-pr-checks
run: |
echo "Pausing before status checks..."
sleep 10
echo "Waiting for required status check 'validate-xml' to pass..."
for i in {1..30}; do
STATE=$(gh pr checks ${{ steps.create-pull-request.outputs.pull-request-url }} --json name,state --jq ".[] | select(.name==\"validate-xml\") | .state" 2>/dev/null || echo "none")
echo "validate-xml = $STATE"
if [[ "$STATE" == "success" || "$STATE" == "none" ]]; then
echo "validate-xml check passed."
break
fi
echo "validate-xml not successful yet, retrying in 10s... ($i/30)"
sleep 10
done
CHECK_OUTPUT=$(gh pr checks ${{ steps.create-pull-request.outputs.pull-request-url }} 2>&1 || true)
echo "CHECK_OUTPUT = $CHECK_OUTPUT"
if echo "$CHECK_OUTPUT" | grep -q 'no checks reported'; then
echo "checks_present=false" >> $GITHUB_OUTPUT
else
echo "checks_present=true" >> $GITHUB_OUTPUT
gh pr checks ${{ steps.create-pull-request.outputs.pull-request-url }} --watch || echo "Check watch failed."
fi
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Fail if any required check failed
if: steps.check-pr-checks.outputs.checks_present == 'true'
run: |
gh pr checks ${{ steps.create-pull-request.outputs.pull-request-url }} > checks.txt
if grep -E '(X|Failed|failure)' checks.txt; then
echo "Some checks failed."
cat checks.txt
exit 1
else
echo "All checks passed."
fi
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down