Skip to content

Conversation

@rudnerbjoern
Copy link
Owner

No description provided.

@rudnerbjoern rudnerbjoern marked this pull request as ready for review September 10, 2025 15:18
@rudnerbjoern rudnerbjoern merged commit 3dec1a5 into main Sep 10, 2025
1 check passed
Comment on lines +259 to +260
<xs:attribute name="id" type="xs:string" use="required" />
<xs:attributeGroup ref="alteredNode" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:attribute name="id" type="xs:string" use="required" />
<xs:attributeGroup ref="alteredNode" />
<xs:attributeGroup ref="alteredIdNode" />

Comment on lines +248 to +250
<xs:element name="label" type="xs:string" minOccurs="0" />
<xs:element name="icon" type="xs:string" minOccurs="0" />
<xs:element name="description" type="xs:string" minOccurs="0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by default all elements should be alterable..

Suggested change
<xs:element name="label" type="xs:string" minOccurs="0" />
<xs:element name="icon" type="xs:string" minOccurs="0" />
<xs:element name="description" type="xs:string" minOccurs="0" />
<xs:element name="label" type="alteredString" minOccurs="0" />
<xs:element name="icon" type="alteredString" minOccurs="0" />
<xs:element name="description" type="alteredString" minOccurs="0" />

Comment on lines +251 to +257
<xs:element name="configuration">
<xs:complexType>
<xs:choice maxOccurs="unbounded">
<xs:any processContents="lax" />
</xs:choice>
</xs:complexType>
</xs:element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="configuration">
<xs:complexType>
<xs:choice maxOccurs="unbounded">
<xs:any processContents="lax" />
</xs:choice>
</xs:complexType>
</xs:element>
<xs:element name="configuration">
<xs:complexType>
<xs:choice maxOccurs="unbounded">
<xs:any processContents="lax" />
</xs:choice>
<xs:attributeGroup ref="alteredNode" /> </xs:complexType>
</xs:element>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants